Hey Brad, I reviewed this before and still think it looks good.
The one suggestion I had was to add EIO to the efail.c test case, since ZFS can return an EIO in situations where it determines that data has been corrupted and is unable to recover. (No replica exists) Based upon our previous conversations, you said that this error code currently confuses the test-suite. I still think it's a worthwhile case to test. Perhaps you could file a bug to enhance this case to support EIO when it's plausible? > The goal of these parts of the test suite is to determine how we fail if we > run out of space, network issues, etc., at various places in the code and then > go fix the code to handle those cases if we blow up. I think you mean when we blow up. ;) Thanks, -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
