On Wed, Sep 24, 2008 at 10:07:47AM -0700, Brad Hall wrote: > http://cr.opensolaris.org/~bhall/bug-3400/
You need to cstyle the C code: /ws/onnv-tools/onbld/bin/cstyle, if you don't have SUNWonbld on your system. Though I'm a bit surprised it doesn't catch that function return values should be on their own line, as well as function open braces. Also, be sure to use void for an empty parameter list in a function definition. And close braces should be on their own lines for lines 62 and 68 of enetfail.c I'm a little surprised that 1% is enough to be useful. Content looks fine. If this grows, you should move shouldfail() into its own C file and share the resulting object between the two shared objects. Or just put everything into a single shared object and choose which you want to test, should you go down that path. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
