On Fri, Sep 26, 2008 at 05:24:01PM -0700, Brock Pytlik wrote: > Looks good to me. > > Nits: > efail.c > line 43: I think a g is missing at the end of the line
Our comments could use some country/southern influence. (OK, fine, fixed) > Random questions: > Could we, or do we even want, to be able to specify a parameter on the > command to adjust the percentage of reads or writes which produce errors? > Might we ever want to only test problems in reading, or writing, or > making dirs separately from the other errors? (Could this be a command > line argument too?) Yeah, we could could do something like that. But it's kind of difficult to get things though to there (aside from environment variables). So maybe we can just do it that way: "PKG_FAIL_PCT=30 PKG_FAIL_SYSCALL=read,mkdir make test-fail", or something along those lines (fail 30% of the time, only fail for read/mkdir system calls ...). Thanks for reviewing. -Brad _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
