> Sure thing.  I hadn't, 'cause in the dark ages when I first started this
> patch, that wasn't an option.  ;-)

Understood.  I just used it for a half dozen import files in the build
100 resync and finally some of them are readable now that their lines
are 80 characters or less.

>>      I noticed the parser is a little bit particular (need to file a
>>      bug on that) so I've been using the convention
>>
>>              add driver name=blah ..... privs=sys_config<space><blackslash>
>>              <tab>devlink="blah......"
>
> Hm, interesting.  It doesn't mind the tab?  I'm surprised you haven't run
> into bug 2686.

It doesn't seem to mind the tab from my testing.  I haven't looked at
the code but might this be a difference between solaris.py and
pkgsend?

>> src/util/distro-import/100/common/SUNWcsd
>>
>>      Although etc/devlink.tab is no longer pulled from SUNWfixes,
>>      you still have the chattr here which seems strange.  What
>>      package ends up owning the file then?
>
> SUNWcsd, at least for now, until bug 14 is fixed.  Note that the default
> devlink.tab file delivered by SUNWcsd is skeletal, so it should be just the
> thing.

Right, of course.

>> src/util/distro-import/Makefile
>>
>>      There have been a few other cases were the cleanup of SUNWfixes
>>      caused earlier build imports to fail (see 3694, for example).
>>      Should this section actually be based on CACHED_FILES (which
>>      includes ELIDED_FILES) rather than just ELIDED_FILES?

dsc
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to