On Mon, Oct 13, 2008 at 06:22:13PM -0700, [EMAIL PROTECTED] wrote: > Now that Rich has fixed the continuation line issue, I've begun > cleaning up import files as I update them. If you could do the > same here, even better. :-)
Sure thing. I hadn't, 'cause in the dark ages when I first started this patch, that wasn't an option. ;-) > I noticed the parser is a little bit particular (need to file a > bug on that) so I've been using the convention > > add driver name=blah ..... privs=sys_config<space><blackslash> > <tab>devlink="blah......" Hm, interesting. It doesn't mind the tab? I'm surprised you haven't run into bug 2686. > src/util/distro-import/100/common/SUNWcsd > > Although etc/devlink.tab is no longer pulled from SUNWfixes, > you still have the chattr here which seems strange. What > package ends up owning the file then? SUNWcsd, at least for now, until bug 14 is fixed. Note that the default devlink.tab file delivered by SUNWcsd is skeletal, so it should be just the thing. > src/util/distro-import/Makefile > > There have been a few other cases were the cleanup of SUNWfixes > caused earlier build imports to fail (see 3694, for example). > Should this section actually be based on CACHED_FILES (which > includes ELIDED_FILES) rather than just ELIDED_FILES? I'm not sure. The profusion of file categories here has confused me a little, so I didn't want to go cleaning this stuff up. I diddled with ELIDED_FILES because that's where devlink.tab was, and once I did that, because sd.conf was there, it was easy to rope in that bug, too. I'd rather not expand the scope here too much without thinking more about the problem, and I really want to get the devlinks bits off my back, so I'd like to put this off for now. Thanks! Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
