On Thu 02 Oct 2008 at 08:02PM, Danek Duvall wrote:
> On Mon, Sep 15, 2008 at 03:53:52PM -0700, [EMAIL PROTECTED] wrote:
>
> > - line 308: Should we be throwing a RuntimeError here? Or, should we
> > be using some other kind of exception?
> >
> > - lines 314, 319, 668, 698: Use emsg instead? Perhaps better still:
> > raise a special exception that contains the relevent error as its
> > __str__ method?
>
> Sorry, never responded to these.
>
> The error handling in actions is rather pathetic. It's a mixture of
> deliberately unhandled exceptions, raised RuntimeErrors, and printing. I
> don't want to fix it for a small handful of cases, particularly since we
> don't yet know what the final solution is going to be. I know Dan hates
> that answer, but I want to put this off. We can make it (as well as most
> of our other sucky error and warning plumbing) a high priority for April.
Well in the mean time we've been chipping away at improving the
exception handling in other parts of the code. So perhaps a
bug or RFE specifically scoped to "improving exception handling
for actions" is now warranted.
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
