Brock Pytlik wrote: > Webrev: > http://cr.opensolaris.org/~bpytlik/ips-5211-v1/ > > Bug: > http://defect.opensolaris.org/bz/show_bug.cgi?id=5211 > cfg_cache needs to be able to live elsewhere
depot.py: line 120: you need to add the new --repo-config-file option here; i'm inclined to say this should just be "--cfg-file" instead of --repo-cfg-file. lines 122-143: I know this sucks, but please re-flow all of these so it lines up with line 144. line 144-145: This really isn't a path, it's the pathname of an alternate configuration file to use instead of the default one. repository.py: line 103: default seems an odd name for this attribute line 133: please don't use the numeric codes here; use errno.EPERM, errno.EACCES, errno.EROFS; also, I wouldn't assign this to perm_code, just use the set() right in the if statement and avoid the unnecessary assignment Can you add a new test to ensure that the depot accepts this as a command-line option, and add it to depotcontroller? -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
