One more time around for this set of changes. http://cr.opensolaris.org/~bpytlik/ips-5211-v3/
Same set as last time, but this didn't go back because I wasn't clear if people were ok with putting this back without the testcase that was discussed off and on. Unless I hear objections, I'm going to put this back relatively soon (think 1-2 days). Brock Brock Pytlik wrote: > Shawn Walker wrote: > >> Danek Duvall wrote: >> >>> On Tue, Nov 25, 2008 at 03:41:29PM -0800, Brock Pytlik wrote: >>> >>> >>>>> t_pkg_depotd.py >>>>> >>>>> - Any way to make sure that it actually read the config file? >>>>> >>>>> >>>>> >>>> None that I know of. I had a difficult telling myself when I was >>>> manually and the method I found (checking whether an icon was >>>> missing) isn't easy to put into the testsuite. I'm open to >>>> suggestions on how to test this though. >>>> >>> Hm. You could put some obvious test data into the config file, retrieve >>> the feed, and see if that data is there. I'm not sure what the simplest >>> thing to check for is -- maybe the feed id? It might also be a bit of a >>> pain to actually make all that happen ... >>> >> The feed id would indeed be the easiest to check for and not too >> painful to get at. >> >> > It turns out that it's a fair bit of work to extract the feed id from > the html feed sent to a client, at least it appears to be to me. Given > the general lack of verification that what the server serves as web > pages is correct, I'm inclined to put off adding this as a test case > until there's more infrastructure support for it and filing a bug noting > that it needs to be fixed. Is that acceptable, or should I allocate time > to add a test case? > > Thanks, > Brock > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
