Danek Duvall wrote:
> On Mon, Nov 24, 2008 at 12:41:05PM -0800, Brock Pytlik wrote:
>
>   
>> http://cr.opensolaris.org/~bpytlik/ips-5211-v2/
>>     
>
> depot.py:
>
>   - line 144: duplicate "file".
>
>   
fixed
> pkg.depotd.1m.txt:
>
>   - line 74: I'd say "... file from which to read the configuration ..."
>
>   
fixed
> repository.py:
>
>   - line 133: no need for "set" -- a tuple works just fine.
>
>   - line 133: in grand UNIX tradition, EACCES is spelled with just one "S".
>
>   - line 134: need a dot between errno and EROFS.
>   
Fixed.
> t_pkg_depotd.py
>
>   - Any way to make sure that it actually read the config file?
>
>   
None that I know of. I had a difficult telling myself when I was 
manually and the method I found (checking whether an icon was missing) 
isn't easy to put into the testsuite. I'm open to suggestions on how to 
test this though.
> Danek
>   

Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to