Shawn, The new page layout and themes are great.
The package display menu assumes that packages are put into the repository with a common release/branch value indicating a set of packages that go together. While this happens to be true for OpenSolaris now, it will not generally be true for other repositories. For example, take a look at the Glassfish V3 Prelude repository: http://pkg.sun.com/glassfish/v3prelude/release/ While many of the packages have 0-28.3 for the release/branch, there are others with 0-15.1269, 0-0, 0-1, and 0-0.2. This will be the case whenever a repository is a collection of packages that are produced by more independent engineering teams. As an alternative, it would be useful to also provide a menu choice for the most recent version of each package (this should be the choice at the top of the menu). shared.shtml, line 56 - hardcoding the mapping from branch numbers to OpenSolaris release names in the code would seem to be a maintenance problem, as this will need to be updated every time OpenSolaris is released. Also, if another project unrelated to OpenSolaris happens to use 0.86, etc. for a branch number, they will get a 2008.05 showing up in the output unexpectedly. While I see how this is useful, it would be preferable if this could be derived from some other information such as a repository configuration file. The idea of mapping numbered branches to more meaningful names would be generally useful for other projects too. The second bullet in the search description "To find packages that contain a specific file by path, include the leading '/': /usr/bin/vim" depends on the resolution of issue 1059, although the issue here has to do with a search on the repository rather than on a local image as is the case in 1059. The use of a "/" at the beginning of the file path is based on the assumption that an image that is going to use this repository has "/" for the root. While this is true for the OpenSolaris repository, it isn't generally going to be true for user images. Also, the search output Value column doesn't match the search input when the leading "/" is used. For example, if you search for /usr/bin/vim, the search values are all usr/bin/vim which doesn't match the what was entered. I would rather see a the following behavior: a) If a search team has a leading slash, first do the search as given. If there are results, display them. b) If there are no results from (a), then strip the leading slash and try the search again. c) Don't mention that a leading slash has to be added to search terms. Thanks. Tom Shawn Walker wrote: > Greetings, > > The following webrev contains changes for the following RFEs: > 3011 new depot index page desired > 3014 revamped depot bui (web ui) desired > > webrev: > http://cr.opensolaris.org/~swalker/pkg-3014/ > > Sample depot themes: > default: > http://ipkg.sfbay:8009/ > > opensolaris.org: > http://ipkg.sfbay:8010/ > > sun.com: > http://ipkg.sfbay:8011/ > > Feedback on all aspects is appreciated. > > Cheers, > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
