Shawn Walker wrote: > Greetings, > > The following webrev contains changes for the following RFEs: > 3011 new depot index page desired > 3014 revamped depot bui (web ui) desired > > webrev: > http://cr.opensolaris.org/~swalker/pkg-3014/ > > Sample depot themes: > default: > http://ipkg.sfbay:8009/ > > opensolaris.org: > http://ipkg.sfbay:8010/ > > sun.com: > http://ipkg.sfbay:8011/ > > Feedback on all aspects is appreciated. > > Cheers, > Search: On the page that appears when a search fails, I'd avoid mention of "keywords" since right now we're not supporting multiple keyword searches.
Feed: On the page that pops up when the feed icon is clicked, the IPS logo seems to be sitting too low, so that the bottom crosses the line of the box it's contained in. I'm also a bit surprised this page isn't themed, but that can come later I'm sure. Browse: It'd be nice if the package info was formatted and organized more clearly. Again, not this release, but something for next maybe. Default theme: I'd expect a bigger "home" button once I've traveled to search, packages, or statistics. I had to look for a while to notice the little, "Home" under the logo. The United States|English in the upper right corner confused me, I'm not sure what the purpose of it is. I would've expected it to be clickable and to take me to other region/language options. Sun.com theme: Again, the home thing was confusing. I think I would've expected clicking on the sun icon in the upper left corner to take me back to the depo homepage, not to sun.com. The blue tinting on the stats page looks nice, but needs to be stronger I think. When I looked at them, on catalog and depot, I can barely see the hint of them in the first row, on operations, it's much stronger and I can see it in the first two rows. The color of the Copyright line in the lower right made me think it was a link, not just text. Opensolaris.org theme: Not a big fan of the green color for the catalog/feed box on the front page and the boxes on the stats page. Maybe you're stuck with it, but it jumped out at me. Same comments about home and the opensolaris logo as I had with the sun.com theme. Coding comments: If the theme is set to something that doesn't exist, it gives a 404 error with "The path '/en/index.shtml' was not found." It would be nice if this included more information or different if the directory for the theme doesn't exist. The placement of the images confused me. I'm not clear why the pkg-block icons are at the top level while the feed icon was down a level. It'd be nice if the depot would display a warning when it encounters illegal values in the style sheets, like a color of ZZZZZZ. It wasn't obvious to me how I'd add another content page to the menu that currently consists of Packages, Search, Statistics. I understand I'd probably have to tweak the depot to generate the content for that page, but how that would get tied into the actual display was unclear. I'm also not sure how I'd handle having some pages work with one theme, and other pages with a different theme. Not for this release because I don't want to anything not in the server subdir at this point, but going forward, we should probably commonize the exceptions where possible, like the version exception. Maybe I'm just currently in love with SMF, but it seems like it'd be nice if the theme was a smf configurable feature. I realize that the changes in the config.shtml file get picked up on the fly, but I think it'd be easier if a deployer had a single interface to deal with things, including changing the actuve theme. Otherwise, as a developer, I think what I'd do is just set the theme to default, and have duplicate demo web-content directories laying around and use SMF to repoint the depot and restart it to make my development life easier. Just an idea for the future. That's all I've got, Brock _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
