Shawn,
> webrev:
> http://cr.opensolaris.org/~swalker/pkg-3014/
I'm not familiar with most of this code, so I'm afraid I don't have a
lot of useful feedback to provide.
I did have an error handling nit.
face.py:
- respond() and __handle_error() both have the potential to return a
500 error. In respond, an IOError that isn't EISDIR will generate a
500 error. It seems like we should be more careful, especially in
this case. There are a bunch of environment errors that probably
aren't 500s, permissions are a good example.
In both cases, however, returning a 500 will cause Apache's
mod_balancer to take us out of the pool. Can we return another
error here, or at least reduce the instances where we might get a
500 error?
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
