> can be found at
> 
>     http://cr.opensolaris.org/~dduvall/pkg-badlocale/

The code looks fine to me.  I would suggest that instead of writing the
same snippet of code in 5 different places, you place this code
in misc.py and call it from those 5 places instead.  I realize that not
every program has the same output routines for the error message, but
perhaps an output function could be passed into the common routine?

-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to