Danek Duvall wrote: > On Thu, Dec 11, 2008 at 02:59:48PM -0800, [email protected] wrote: > >>> can be found at >>> >>> http://cr.opensolaris.org/~dduvall/pkg-badlocale/ >> The code looks fine to me. I would suggest that instead of writing the >> same snippet of code in 5 different places, you place this code >> in misc.py and call it from those 5 places instead. I realize that not >> every program has the same output routines for the error message, but >> perhaps an output function could be passed into the common routine? > > Yeah, that thought crossed my mind. I noted the problem with the different > output routines, but didn't go so far as to think of passing in a function > to do that. It seems on the boundary to me; does anyone else have opinions > on this?
This functionality seems rather useful to any of our clients. Having the code in one place would be nice to make it easier to update and to add to new clients. Your code looks fine too. Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
