Looks good from GUI point of view. Padraig
On 12/11/08 22:54, Danek Duvall wrote: > A short review for > > 5778 Inability to set locale leads to stack trace > > can be found at > > http://cr.opensolaris.org/~dduvall/pkg-badlocale/ > > We've run into this through two means -- one via the "run man as root and > have it remove the .so file that lets the locale work" bug and the other > where we split locale packages up but forgot to include dependencies so > people upgrading don't get the locales installed on their systems that they > should. It's a trivial bug to work around, but it's annoying, and > reasonably easy to fix, at least to this level (the bug report has a > suggestion for further improvements, but that's perhaps overkill). > > The idea is to try to set the locale, spit out a useful error if it didn't > work, and fall back to the C locale. I've put the code in all five > programs that currently call setlocale(), though when trying it out with > packagemanager, I notice that gtk already spits out a warning about it and > that it's reverting to C. I don't know if this reversion is just for the > gtk portions, or whether it's program-wide, making this change unnecessary, > so some verification from the GUI folks would be good here. > > Thanks, > Danek > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
