[email protected] wrote: >> In any case, Danek, you had it right. The output is "file 0 1". I was >> unware of how magical join()-ing a string to a list of strings could be. > > Alright. I added a list comprehension to _valid_versions_test() that > should cope with multiple version numbers on the same line. > > I'm pushing a new webrev with all of the recent changes. It lives here: > > http://cr.opensolaris.org/~johansen/pkg-686-3/ > > Feel free to send along any last comments/complaints.
These changes seem fine to me. Only comment I have is that it would be interesting to see a test case setup here by instantiating a BaseHTTP server and having it respond incorrectly to any URL request by the pkg client. Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
