On Fri, Jan 23, 2009 at 03:13:26PM -0800, [email protected] wrote: > > retrieve.py: > > > > - line 93, 415: no spaces around equals in argument lists. > > Ok, fixed. I had always done it this way before; however, I thought I > remembered some style guideline that said there should be spaces. Is > this a case where you disagreed with a PEP on style and as a result, > different reviewers began issuing differing guidance for argument lists?
That'd be the issue. We conceded to PEP8 on many things, including no spaces around equals signs in argument lists, but not on 4-space indents. > > - line 1504: "supported". This is a weird failure mode -- we just > > retrieved what appears to be a well-formed response to versions/0 that > > indicates that versions/0 isn't supported? Perhaps this should be > > labeled "Epic fail". > > I finally remebered the purpose of this check. I haven't been able to > get a straight answer from anyone about the actual supported format of > versions/0. > > If we introduce another version of a protocol, what is the output of > versions supposed to be? > > file 0 > file 1 > > or > > file 1 0 The latter. At least, that was the intent; dunno if the server would still do that, but it should be easy to check. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
