> > - line 1551, 1539: replace with > > > > authlist = [ > > auth > > for auth in auths > > if self.valid_authority_test(auth) > > ] > > This whole section of code is half-baked and needs a re-write. IIRC, > authlist was supposed to be all of the existing authorities in the case > where none were passed in. If, however, the caller passed one or more > authorities, authlist should be the authorities passed in as well as the > previously known authorities. I introduced a CfgCacheError in case no > authorities were pre-existing. It looks like I catch that error in > cache_catalogs instead of retrieve_catalogs. I think it makes more > sense to generate this list in retrieve, and pass it to cache_catalogs. > I think I had started to do this, but got distracted by something else > and forgot to finish the rest of the pieces. I'll see if I can fix this > up a bit.
I take that back. It looks like I pushed the list concatenation into cache_catalogs instead of retrieve. I double-checked that code, and it does seem correct. I'll re-write these as list comprehensions, but only one needs the valid authority test. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
