On Wed, Jan 28, 2009 at 04:14:36PM -0800, [email protected] wrote: > http://cr.opensolaris.org/~johansen/webrev-6222/
I'm not sure I agree that bad fmris in a catalog is a retryable exception (except in the truncated catalog case). It's more likely that the catalog data itself is bad, and that trying again won't give us any better results. And since we're dropping the bad catalog entries on the floor anyway, we probably don't have to raise an exception at all. Now, it might be nice to warn the user, or log something, but being silent is probably fine for now. In updatelog.py, only the PkgFmri construction needs to be in the try block; the stuff dealing with "line" can be outside it, and thus not quite as squished to the right. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
