> > http://cr.opensolaris.org/~johansen/webrev-6222-3/ > > Don't even bother collecting all the bad fmris. Set bad_fmris to None > initially, set it to the exception if you get one, and test "if bad_fmris" > when you get there. > > Otherwise, looks fine.
Ok, no problem. I've changed catalog/updatelog to store just the last IllegalFmri exception. It'll raise that, if it's not None. I updated the webrev in-place, since the changes were small. I'm re-testing now. I'll push soon unless anyone has further comments. Thanks for the review, sir. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
