On Wed, Feb 04, 2009 at 12:55:44AM -0600, Shawn Walker wrote: > I've put a change in place that ensures that "required" attributes > (which as far as I can tell is just the key_attr from an action class) > is checked for during fromlist and fromstr, and then raises an > appropriate ActionError exception.
There are two categories of "required" attributes. There are the semantically required attributes, such as key_attr (and, I think, target, in the case of links), and then a set of other attributes which the actions currently expect to be there, but could, if desired, make up reasonable values. This latter group includes owner, group, and mode for filesystem actions, for instance. I'd hoped to get to the attribute synthesis a long time ago, but have always been a bit worried that it's the wrong idea. We can require them explicitly now, and always back off on that later. > I'm just afraid of a user ending up with a toxic manifest that keeps > them from doing anything on their system. Well, requiring attributes isn't going to change this situation. Right now, their client will crash if an attribute isn't there. Better, I expect, to quit with a useful error message than a stack trace. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
