[pkg-discuss] Looking for code reviewers.

Rich Burridge Tue, 09 Jun 2009 08:27:37 -0700

Now that the pkg gate is open again, I'd like to try to check
in some of the potential fixes I've got for various bugs. I'm
looking for code reviewers for some of them.


Here's a summary:

2721 image.__load_pkg_states creates extra PkgFmri objects
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=2721

Last message:http://mail.opensolaris.org/pipermail/pkg-discuss/2009-May/013312.html

Last webrev: http://cr.opensolaris.org/~richb/pkg-2721-v1/

I have two +1's for this one already (from Shawn & Tom) and will
check it in soon.

----

4134 pkg operations should report operation sizes
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=4134

7736 image plan should provide space requirements for operation
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=7736

Last message:http://mail.opensolaris.org/pipermail/pkg-discuss/2009-May/013742.html

Last webrev: http://cr.opensolaris.org/~richb/pkg-4134-v3/

----

4178 unfound_fmris is a poor name
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=4178

Last message:http://mail.opensolaris.org/pipermail/pkg-discuss/2009-May/013539.html

Last webrev: http://cr.opensolaris.org/~richb/pkg-4178-v2/

----

4346 use of ctime() creates non-localized time strings
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=4346

Last message:http://mail.opensolaris.org/pipermail/pkg-discuss/2009-May/013446.html

Last webrev: http://cr.opensolaris.org/~richb/pkg-4346-v1/

I have one +1 from Shawn so far.

----

4395 Use pkg.summary for "pkg info" output
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=4395

8829 solaris.py should be able to add pkg.summary attributes
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=8829

Last message:http://mail.opensolaris.org/pipermail/pkg-discuss/2009-May/013515.html

Last webrev: http://cr.opensolaris.org/~richb/pkg-4395-8829-v2/

----

4470 passwd/group "compat" entries cause stack trace
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=4470

Last message:
Last webrev:

----

4542 malformed group file causes client traceback
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=4542

Last message:http://mail.opensolaris.org/pipermail/pkg-discuss/2009-April/013188.html

Last webrev: http://cr.opensolaris.org/~richb/pkg-4542-v1/

I have one +1 from Danek so far but Shawn has asked me to write a
test case for it. Once I've done that, I'll post a new webrev and ask
for another code review.

----

5707 depot should support SIGHUP to refresh configuration
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=5707

Last message:http://mail.opensolaris.org/pipermail/pkg-discuss/2009-May/013432.html

Last webrev: http://cr.opensolaris.org/~richb/pkg-5707-v2/

----

6088 SVr4 datastream bundles don't convert links (hard or soft)
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=6088

Last message:http://mail.opensolaris.org/pipermail/pkg-discuss/2009-May/013317.html

Last webrev: http://cr.opensolaris.org/~richb/pkg-6088-v2/

Also took the change suggested by Danek:

   if p.type in "ls":

and have adjusted by workspace accordingly (no new webrev).

I have one +1 from Shawn so far.

----

8938 openoffice-xy localization packages should depend on openoffice
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=8938

Last message:http://mail.opensolaris.org/pipermail/pkg-discuss/2009-May/013660.html

Last webrev: http://cr.opensolaris.org/~richb/pkg-8938-v1/

I have a +1 from Jan Hnatek on this so far. Probably also needs
a review from David (Comay).

----

8970 Add some classifications to the 'studio' import file.
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=8970

8976 Adjust gen_os_files.py script to allow multiple classifications perpackage.

Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=8976

Last message:http://mail.opensolaris.org/pipermail/pkg-discuss/2009-May/013603.html

Last webrev: http://cr.opensolaris.org/~richb/pkg-8970-8976-v1/

----

9002 check_classifications.txt should be adjusted for new post
    2008.11 classifications.
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=9002

Last message:http://mail.opensolaris.org/pipermail/pkg-discuss/2009-May/013728.html

Last webrev: http://cr.opensolaris.org/~richb/pkg-9002-v2/

This one needs Dan or Stephen (or whoever) to tell me where the
static file "located somewhere centrally (like a DTD would be)
on opensolaris.org (similar to how DTDs work) or on opensolaris.com
or on sun.com." should be.

When I have that, I can adjust the webrev accordingly and ask for codereview.


----

9170 solaris.py script should set mode of "?" directory to 0755
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=9170

Last message:http://mail.opensolaris.org/pipermail/pkg-discuss/2009-May/013776.html

Last webrev: http://cr.opensolaris.org/~richb/pkg-9170-v1/

I also have the change suggested by Danek:

   if manifest.type in "dx":

and have adjusted by workspace accordingly (no new webrev).

I have +1's from Danek and Bart on this one and will
check it in soon.

====
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

[pkg-discuss] Looking for code reviewers.

Reply via email to