Rich Burridge wrote:
4395 Use pkg.summary for "pkg info" output
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=4395
8829 solaris.py should be able to add pkg.summary attributes
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=8829
Last message:
http://mail.opensolaris.org/pipermail/pkg-discuss/2009-May/013515.html
Last webrev: http://cr.opensolaris.org/~richb/pkg-4395-8829-v2/
Can you double check that this passes the test suite? Specifically, I'm
not sure how test_info_local_remote in t_api_info is passing the test at
line 181, but your change suggests that it shouldn't. The pkg in the
test suite only has description set, and not summary, so I'm unclear as
to how anything is coming back from the API call. In any case, I'd like
to see the tests in both t_api_info and t_pkg_info augmented to check
that the new info is both returned, and displays, correctly.
The change itself in api.py looks fine to me. You might consider
breaking out of the loop after setting summary, but that's a minor nit.
The changes in solaris.py look fine to me, though I'm curious is the
section from 706-726 is the section that's turning "summary" into
"pkg.summary". I'm not sure I quite get the importer magic that's
handling that transition.
Thanks,
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
