Danek Duvall wrote:
On Wed, Jun 10, 2009 at 02:55:05PM -0700, Rich Burridge wrote:
Thanks. Looking for one more reviewer.
http://cr.opensolaris.org/~richb/pkg-4395-8829-v5/
In api.py, you retrieve "description" and "pkg.summary" in different ways.
Why not:
summary = mfst.get("pkg.summary", "")
if not summary:
summary = mfst.get("description", "")
or even
summary = mfst.get("pkg.summary", mfst.get("description", ""))
Unfamiliarity with the pkg code. I like the second one better.
Do you need to see another webrev or are you okay with me
making this change, retesting it, and then checking it in?
Also, note that for the "description is the long description" piece of the
puzzle, the package attribute will be "pkg.description" and not
"description". The latter will always be the old attribute name for
"pkg.summary". The potential variable name conflict in the PackageInfo
object is a different issue entirely.
Noted.
Thanks.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
