Rich Burridge wrote:
Shawn Walker wrote:
Rich Burridge wrote:
Shawn Walker wrote:
Rich Burridge wrote:
Brock Pytlik wrote:
B.t.w, where does this get documented? In other words, what file should I change (as part of this new webrev) that will mention this API change?

Under the doc directory, there's a file called client_api_versions.txt. That's the place to make the change. You should also bump the version in api.py and reset the compatibility set (which will mean corresponding changes in client.py, packagemanager, updatemanager, and a set of test cases).

Okay, I think I have them all changed now.

And I've re-run the test suite on the changed code.

New webrev at:

 http://cr.opensolaris.org/~richb/pkg-4178-v4/

If you're bumping the API incompatible, then you probably need to fix whatever incompatible changes there are in the GUI as well and bump any API versions it uses.

I thought I did that. What did I miss?

Sorry, I missed the gui/modules/misc.py.

I assume you've checked the GUI then for its description/summary behaviour?

Isn't that in the other webrev I currently have out for review (bugs #4395 and #8829)?
This one is for "unfound_fmris is a poor name".

Yes, sorry.

--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to