Rich Burridge wrote:
Brock Pytlik wrote:
Rich Burridge wrote:
Danek Duvall wrote:
On Tue, Jun 09, 2009 at 01:57:08PM -0700, Rich Burridge wrote:
http://cr.opensolaris.org/~richb/pkg-4178-v3/
The moniker "unfound" still appears in api.py and api_errors.py; I
thought
the plan was to make the change there, too, since you were waiting
until
after 2009.06 shipped.
Brock's reply at:
http://mail.opensolaris.org/pipermail/pkg-discuss/2009-April/013029.html
convinced me otherwise.
Did I get confused (again)?
I think what I was saying was if you were going to land this before
the release, the API change had me worried since it could've broken
the gui. Since we're post release, I'm fine with changing it and
documenting the change like we do with other api changes.
Ah. Okay. Then I'll go back to what was the essentially the first webrev.
New webrev tomorrow.
B.t.w, where does this get documented? In other words, what file should
I change (as part of this new webrev) that will mention this API change?
Thanks (and to Danek as well).
Under the doc directory, there's a file called client_api_versions.txt.
That's the place to make the change. You should also bump the version in
api.py and reset the compatibility set (which will mean corresponding
changes in client.py, packagemanager, updatemanager, and a set of test
cases).
On a larger note, while I think all these safeguards may have had a
place at one time, I'm wondering whether we can't simplify things at
least a bit... maybe at least have all the test suites share a client
API version so we don't have to change umpteen files? Since those are
tested anyway, I think i'd be ok with them sharing that variable, or
maybe even pulling it from client.py. The ones in client, PM and UM
should probably remain, though I'd be open to suggestions on why it's
time for them to go too.
Not your job to fix that Rich, just thinking out loud because the
overhead for the api versions is larger than we might like.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
