On Mon, Jun 15, 2009 at 07:30:32AM -0700, Rich Burridge wrote:

> 5707 depot should support SIGHUP to refresh configuration
> Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=5707
>
> Last message: 
> http://mail.opensolaris.org/pipermail/pkg-discuss/2009-May/013432.html
> Last webrev: http://cr.opensolaris.org/~richb/pkg-5707-v2/

depot.py:

  - line 157: nit: remove period for consistency

  - line 164: this isn't strictly true, since you're also handling SIGUSR1
    with this method.

  - line 171, 172: no need for "_e" instead of just "e" here.

Otherwise, it looks fine to me, but I'd want Shawn to confirm the details.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to