On Jun 15, 2009, at 12:36 PM, Danek Duvall wrote:
On Mon, Jun 15, 2009 at 07:30:32AM -0700, Rich Burridge wrote:
5707 depot should support SIGHUP to refresh configuration
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=5707
Last message:
http://mail.opensolaris.org/pipermail/pkg-discuss/2009-May/
013432.html
Last webrev: http://cr.opensolaris.org/~richb/pkg-5707-v2/
depot.py:
- line 157: nit: remove period for consistency
- line 164: this isn't strictly true, since you're also handling
SIGUSR1
with this method.
- line 171, 172: no need for "_e" instead of just "e" here.
Otherwise, it looks fine to me, but I'd want Shawn to confirm the
details.
modules/server/depot.py:
lines 157-159: This isn't needed since SIGHUP causes an execve.
Please test after removing (I thought we had already covered this?)
line 164: this should only be SIGUSR1.
cli/t_pkg_depotd.py:
line 226: I'd just say that you are testing depotcontroller
refres() and avoid mentioning the specific signal.
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
