On Mon, Jun 15, 2009 at 07:30:32AM -0700, Rich Burridge wrote:

> 8970 Add some classifications to the 'studio' import file.
> Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=8970
>
> 8976 Adjust gen_os_files.py script to allow multiple classifications per 
> package.
> Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=8976
>
> Last message: 
> http://mail.opensolaris.org/pipermail/pkg-discuss/2009-May/013603.html
> Last webrev: http://cr.opensolaris.org/~richb/pkg-8970-8976-v1/

gen_os_files.py:

  - line 104, 268: more Pythonic to say

        for i, (category, sub_category) in enumerate(zip(categories, 
sub_categories))

    though that turns out to be a pretty long line.  I personally would
    probably shorten some of the variable names, but if you want to stick
    with the range() call, at least get rid of the explicit starting point,
    as 0 is implicit when left out.

  - line 316: no need for len() calls here.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to