On Jun 15, 2009, at 7:26 AM, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-1835-v2/, fixes
1835 Package Manager should use GNOME proxy settings

This changes causes the desktop files to invoke a python script, pm- gksu_with_http_proxy, which sets the environment variable http_proxy, if required, and then launches /usr/bin/packagemanager or /usr/lib/pk-updatemanager instead iof calling them directly.


Instead of calling this script "pm-gksu_with_http_proxy", might I suggest a more generic name, such as "pm-gksu"? Not only is that less unwieldy, but since you may add things unrelated to http proxy, and since you also need to deal with https_proxy, I think it makes more sense to keep it generic.

Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to