Ok - looks good to me.
JR
Padraig O'Briain wrote:
I have spun another webrev,
http://cr.opensolaris.org/~padraig/ips-1835-v3/, to address two issues:
1) The launch program is now called /usr/lib/pm-launch
2) Changed while loop to for loop in launch.py
Padraig
jmr wrote:
OK - looks good if the sole purpose here is to make sure the behavior
of the PM and UM is the same from the menus as it is from the
terminal. As Gnome Terminal does the right thing and sets the user
proxy settings into the user environment for the program you are
launching from the terminal.
When we move to using the API to check for updates, which will
trigger an image plan we could have a similar issue in UMN. Something
to track.
Few comments:
Agree with Shawn about the name change to give it a more generic
launcher name, such as /usr/lib/pm-launcher.
Would change this to a for loop, logic is simpler and cleaner:
gksu_with_http_proxy.py
args = sys.argv[1]
i = 2
while i < len(sys.argv):
args = args + ' ' + sys.argv[i]
i += 1
JR
Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-1835-v2/, fixes
1835 Package Manager should use GNOME proxy settings
This changes causes the desktop files to invoke a python script,
pm-gksu_with_http_proxy, which sets the environment variable
http_proxy, if required, and then launches /usr/bin/packagemanager
or /usr/lib/pk-updatemanager instead iof calling them directly.
Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
