On Mon, Jun 15, 2009 at 01:26:32PM +0100, Padraig O'Briain wrote: > The webrev, http://cr.opensolaris.org/~padraig/ips-1835-v2/, fixes > 1835 Package Manager should use GNOME proxy settings > > This changes causes the desktop files to invoke a python script, > pm-gksu_with_http_proxy, which sets the environment variable http_proxy, > if required, and then launches /usr/bin/packagemanager or > /usr/lib/pk-updatemanager instead iof calling them directly.
I took a look at the webrev and the information in bug 1835. This appears to only solve part of the problem. The request in the bug report states that updatemanager should pull the proxy settings from gconf, but let the environment variables override this configuration, if they exist. The webrev seems to use the value from gconf to set the environment variable, and doesn't account for whether that value was already set. It also doesn't allow the client to update the proxy configuration, should the value be changed in the GNOME proxy settings. This doesn't seem like a great way to solve the problem. Once the new transport is integrated, it becomes possible to set the proxy on a per-request basis. Right now, the preliminary transport wad looks at just the environment, but we'll need a solution that satisfies a customer-based RFE 6901. If I'm reading 1835 correctly, it means we now have three different places in our architecture where we would allow customers to set proxy configuration information. 1. The pkg configuration 2. The environment 3. The GNOME configuration Packagemanager will need to work correctly in the face of all of these configuration choices. I don't think the GNOME configuration should overrride the environment or the pkg(5) proxy choices. If neither are configured, I don't have a problem with consulting the GNOME config, but that should be dynamic, i.e. it changes with changes to the settings. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
