Shawn Walker wrote:
On Jun 24, 2009, at 6:31 PM, Brock Pytlik wrote:
Shawn Walker wrote:
On Jun 24, 2009, at 8:24 AM, Padraig O'Briain wrote:
I have looked at this to understand how I will use it to accept
licenses in the GUI.
Currently, we call plan_install, prepare and execute_plan from
api.py to install packages. Is there an interface defined which we
can use to get the ImagePlan object after plan_install?
I thought there was, but apparently not. It is my opinion that the
make_*_plan functions should be changed to return the ImagePlan
(that seems fairly logical).
Brock, what are your thoughts?
I'm against returning an ImagePlan object, as that exposes the
internal interfaces to the client, setting us up for the same
problems we used to have with image.py changing. We have a plan
description object and a way to retrieve it. If that object doesn't
provided the needed information, I think the right thing to do is to
improve that object and interface.
Ah, I had forgotten we had a plan description object.
Then yes, the PlanDescription object will have to change to expose the
relevant information.
The one quandry I have is what to do what the set_license_[status?]()
function I was originally going to have on ImagePlan. It seems like I
will need to change PlanDescription to have a private reference to the
ImagePlan, and just have a wrapper function that manipulates the
private ImagePlan reference.
Cheers,
Bart's thinking of some changes to the PlanDescription object so you
might want to talk to him to see if you're thinking about making similar
changes.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
