Brock Pytlik wrote:
Saurabh Vyas wrote:
Hi All,
Please review the fix for:
Bug-id : 9693 RuntimeError on line 125 of query_parser.py doesn't
fill in %s
webrev : http://cr.opensolaris.org/~saurabhv/fix-9693/
and let me know your comments.
Cheers,
~Saurabh
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Thanks Brock for reviewing and correcting this fix.
Yes it should be t.value which we should be printing (I tried
conforming this with the o/p, but could not tweak the rules to do so :-( ).
Apart from the code point of view, I check the client/api.py where the
in-built error object is returned when the parsing exception occurs.
Earlier I assumed that the token itself is passed as 't' when the
parsing exception occurs (wrong to have such assumption ).
I have modified the webrev too, please have a quick review and let me
know if this looks good
http://cr.opensolaris.org/~saurabhv/fix-9693-01/
Thanks again,
~Saurabh
I'm not certain that t is what should be printed. I would guess that
it's t.value, but I'm not certain. Could you show us the output of it?
I'm also not sure that, given the current lexing rules, it's actually
possible to produce a lexing error at all, so it might be necessary to
tweak the rules a bit so that you can make this error happen.
Thanks,
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
