LGTM. Both the output and the webrev look right to me. Thanks for doing
this :)
Brock
Saurabh Vyas wrote:
Thanks again Brock for clarifications.
Here is the new webrev : http://cr.opensolaris.org/~saurabhv/fix-9693-02/
I have attached the snip of the error o/p in mail (so as to avoid the
formatting issue by thunderbird )
Here I am repeating the query string in another line so that the carat
symbol will point to the right location even if the message is localized.
Please let me know if this look good.
Thanks again,
~Saurabh
Brock Pytlik wrote:
Ok, this looks about right to me. I'd like to see it posted on
cr.opensolaris.org because I'm not sure exactly what Thunderbird does
with spacing. Specifically, it looks to me likes the lines starting
with "%s" are indented 5 or 6 spaces from the line starting with
raise, they should be indented 4 spaces. I'd also get rid of the line
break variable and just do "\n".join(["Unable... . Also, please add
the _() construction around the error messages so that they're
translated appropriately. (Also, the line_break = "\n" line looks
strangely indented compared to the others. We'll need one more person
to sign off on it, which hopefully won't take long once it's up on
cr.opensolaris.org.
Thanks,
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
