On Tue, Jul 28, 2009 at 03:08:48PM +0530, Saurabh Vyas wrote:

> http://cr.opensolaris.org/~saurabhv/fix-9693-02/

It looks correct, but I'm curious why you'd want the string repeated twice
in the output.  Perhaps just drop the first instance of it?

You might also put the numerical position into the error, so that someone
cutting and pasting the error, feeding it through mail, etc, doesn't end up
garbling the position marker.  I don't know how obvious it would be in
practice; Brock would have a better feel for that.  Also, an unparseable
character might also be something that doesn't show up in a terminal, and
might need to be hex encoded, but I'm pretty sure that's outside the bounds
of this fix.  :)

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to