Danek Duvall wrote:
On Mon, Aug 03, 2009 at 11:00:05AM +0530, Saurabh Vyas wrote:
Thanks Danek for your inputs, I have not changes the error msg to
point out position too (see the attached snippet).
Looks good to me.
I don't know how obvious it would be in practice; Brock would have a
better feel for that. Also, an unparseable character might also be
something that doesn't show up in a terminal, and might need to be hex
encoded, but I'm pretty sure that's outside the bounds of this fix. :)
Do I need to dump the hex code here ?
No ("outside the bounds of this fix").
Definitely :)
I'm fine with this if Brock is.
Thanks,
Danek
LGTM as well. If you'd send me your hg export, I'll push it to the gate.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
