On Thu, Jan 14, 2010 at 05:30:19PM -0800, Danek Duvall wrote:
> [email protected] wrote:
> 
> >     http://cr.opensolaris.org/~johansen/webrev-13908/
> 
> transport.py:
> 
>   - line 511: You have an extra "_get" in there.

Thanks, fixed.

>   - line 540: why are you returning a stringio object instead of the
>     string itself?  Was that something Shawn asked for?

Yes.  In general, I would have returned the string, but Shawn asked that
the return value be a StringIO object.  I can change this to return a
string and have the caller pull that into a StringIO if it is
preferable.

-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to