[email protected] wrote:

> On Thu, Jan 14, 2010 at 05:30:19PM -0800, Danek Duvall wrote:
> > [email protected] wrote:
> > 
> > >   http://cr.opensolaris.org/~johansen/webrev-13908/
> > 
> >   - line 540: why are you returning a stringio object instead of the
> >     string itself?  Was that something Shawn asked for?
> 
> Yes.  In general, I would have returned the string, but Shawn asked that
> the return value be a StringIO object.  I can change this to return a
> string and have the caller pull that into a StringIO if it is preferable.

I don't really care too much, as long as there's some consistency.  Right
now, we generally turn the data into the obvious object -- a Manifest, a
Catalog, etc.  Not sure what that would be here.  A string is what I'd
expect, and I'm curious how Shawn is going to use the stringio object, but
like I said, I don't really care.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to