On 07/28/10 03:17 AM, Saurabh Vyas wrote:
Hi All,

Please review this fix and let me know your comments.

Bug-id : 14198 bootenv unmount failure could provide more useful failure
message
webrev : http://cr.opensolaris.org/~saurabhv/Bug-14198-rev0/

Its a simple change it he error log msg.

When a string that will be translated contains more than one value, named format specifiers must be used. Also, the "pkg: " shouldn't be there, so I'd change this to something like:

logger.error(_("unable to unmount BE %(be_name)s "
    "mounted at %(be_path)s") % {
    "be_name": self.be_name_clone,
    "be_path": self.clone_dir })

Cheers,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to