Hi All,
I finally got the test running fine for this fix & also got this fix
verified (by Shawn).
I have attached the 'hg export' o/p, please if some on can push this fix.
Thanks in advance,
~Saurabh
On 09/ 3/10 03:06 AM, Shawn Walker wrote:
On 09/ 2/10 04:00 AM, Saurabh Vyas wrote:
On 08/21/10 12:01 AM, Shawn Walker wrote:
On 08/19/10 02:31 AM, Saurabh Vyas wrote:
Hi Shawn,
Can you please provide your comments on this fix.
webrev :
http://cr.opensolaris.org/~saurabhv/Bug-14198-rev1/
Also do I need a successful test run for this fix (as only error
msg is
modified in this fix) ?
If so, I am planning to run the test again on latest OSOL (146).
This change seems fine.
You should have at least one successful test run, which you should be
able to achieve with the latest gate tip on build 146.
-Shawn
Hi Shawn,
Finally I got the test run successful (on a 146 machine).
Test o/p :
v...@gladiator:~/IPS/pkg-gate/src# make test
/usr/bin/python2.6 setup.py test
running test
# Accessibility not enabled, GUI tests disabled.
# logging to /tmp/tmp9CjzEG.pkg-test.log
.........................................................................................................................................................................................................................................................................................................................
# ----------------------------------------------------------------------
# Ran 313 tests in 407.973s
..........................................................................................................................................................................................................................................................................................................................................................................................................................................
# ----------------------------------------------------------------------
# Ran 426 tests in 2467.940s
Please let me know if its fine to push the fix.
I think it would be fine to push the fix. Please email the list
requesting that someone does so assuming that you don't already have
commit access.
-Shawn
# HG changeset patch
# User [email protected]
# Date 1283516281 -19800
# Node ID 050846409243da32fb688f93bdd5949f173c4025
# Parent 552262a56a9a120793ffdf9d63f7dfca00d1d4d8
14198 bootenv unmount failure could provide more useful failure message
diff -r 552262a56a9a -r 050846409243 src/modules/client/bootenv.py
--- a/src/modules/client/bootenv.py Mon Aug 30 16:11:30 2010 -0500
+++ b/src/modules/client/bootenv.py Fri Sep 03 17:48:01 2010 +0530
@@ -351,8 +351,10 @@
self.img.history.log_operation_end()
if be.beUnmount(self.be_name_clone) != 0:
- logger.error(_("pkg: unable to unmount %s") \
- % self.clone_dir)
+ logger.error(_("unable to unmount BE "
+ "%(be_name)s mounted at %(be_path)s") % {
+ "be_name": self.be_name_clone,
+ "be_path": self.clone_dir })
return
os.rmdir(self.clone_dir)
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
