Shawn Walker wrote:
When a string that will be translated contains more than one value,
named format specifiers must be used. Also, the "pkg: " shouldn't be
there, so I'd change this to something like:
logger.error(_("unable to unmount BE %(be_name)s "
"mounted at %(be_path)s") % {
"be_name": self.be_name_clone,
"be_path": self.clone_dir })
Thanks Shawn for your inputs.
I have made the necessary correction, new webrev :
http://cr.opensolaris.org/~saurabhv/Bug-14198-rev1/
Also I ran the test suite & got following result :
# Ran 368 tests in 1905.324s
FAILED (successes=361, failures=7, errors=0, mismatches=7)
======================================================================
BASELINE MISMATCH: The following results didn't match the baseline.
----------------------------------------------------------------------
cli.t_pkg_depotd.py TestDepotController.test_writable_root: fail
cli.t_pkg_depotd.py TestDepotOutput.test_0_depot_bui_output: fail
cli.t_pkg_search.py TestPkgSearchBasics.test_bug_10515: fail
cli.t_pkg_search.py TestPkgSearchBasics.test_bug_12271_14088: fail
cli.t_pkg_search.py TestPkgSearchBasics.test_pkg_search_cli: fail
cli.t_pkg_search.py TestPkgSearchBasics.test_remote: fail
cli.t_pkgdep.py TestPkgdepBasics.test_bug_13059: fail
----------------------------------------------------------------------
Are these failures expected ? (Or I am missing anything?)
Thanks,
~Saurabh
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
