Hi all, I was wondering if I could get a code review for a few pkglint bugfixes and enhancements please?
http://cr.opensolaris.org/~timf/pkglint-misc-webrev The build with this changeset is now pkglint-clean, and will fail if it isn't. We get some warnings produced from the check that ensures we're not depending on any obsolete packages. We need to lookup each package dependency before checking that package for obsoletion. If we fail to find that dependency, we report a warning. I believe this warning is actually quite useful because it has the side-effect of checking that a package author hasn't made a typo in their depend action 'fmri' attribute value. If we lint against a reference repository that contains these dependencies, those messages go away. If folks think the build is too noisy with these errors, I can grep -v those particular messages out of the way. (the mechanism to exclude checks from pkglint would prevent us from running that check altogether, as opposed to just preventing the logging of particular messages within that check, which may itself be a worthy RFE) The output of 'make packages' in a gate with these changes is at http://cr.opensolaris.org/~timf/pkglint-misc-webrev/make-packages-output.txt Output of a pkglint run on on-nightly at build nv_147, running with ptime(1) is at http://cr.opensolaris.org/~timf/pkglint-misc-webrev/snv_147\-pkglint.txt cheers, tim _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
