Tim Foster wrote:
> http://cr.opensolaris.org/~timf/pkglint-misc.hg
[That's a typo; it's at the old location, AFAICT.]
pkg/Makefile:
- line 147, et al: it's more common for us ON-ophiles to put the "then"
on the same line as the conditional itself.
- line 152: just a simple "else", maybe?
- line 158: wouldn't using sed result in a more compact command? Also,
since you're not re-using pkglint-out.txt, why not just run pkglint and
the substitution/sort as a single pipe? Indeed, even the diff can be
brought in on it:
(pkglint ... > /dev/null) 2>&1 | \
sed -e 's/@[0-9TZ.:,-]*//g' | \
sort | \
diff pkglint_whitelist.txt - > pkglint-out-diff.txt
- line 164, 167: Is the -e is necessary?
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
