Tim Foster wrote: > That makes sense alright, I've added that to this webrev: I have this so > that reference repository lint runs won't redirect stdout/stderr and > pkglint errors (not warnings) will cause the build to fail. I anticipate > that people will use this rarely, and will want to see what's going on if > they're using it.
I'm a bit confused. The new webrev now has pkglint run twice if PKGLINT_REF_REPO is defined. I would expect just the one run, against the reference repo. I don't think you can have a blank line in a make rule (line 150). > > ERROR opensolaris.action001.1 Username pkg$:::$::$:$:$:5srv in > > pkg://pkg5-nightly/package/pkg > 8 chars > > ERROR opensolaris.action001.3 Username pkg$:::$::$:$:$:5srv in > > pkg://pkg5-nightly/package/pkg is invalid - see passwd(4) It occurs to me that if we end up with expected errors that are no longer there, they should count only as warnings, and not build-breakers. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
