On 09/15/10 06:40 PM, Danek Duvall wrote:
Tim Foster wrote:
- line 152: just a simple "else", maybe?
Well, I'm using a separate make statement because I'd like to ignore any
errors produced, prefixing the if-statement with a '-'
Sorry; I keep not seeing that there's no continuation from the previous
line.
I guess I could redirect the stderr/stdout from the ref repo lint run,
and print them once the command completes, but printing the progress
tracker during the lint run would seem to be a bit more user friendly.
Yes.
http://cr.opensolaris.org/~timf/pkglint-misc-webrev
Looks nice.
Thanks!
Note that I still haven't reviewed any of the pkglint code itself. I don't
know if Brock looked at it and simply had no comments, but you should make
sure it's gotten *some* review before putting back.
I reviewed the code (well the original webrev) and had a few comments
which Tim's addressed as far as I know. I can take another pass over
things if that's needed.
Brock
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
