On 01/27/11 08:39 PM, Tim Foster wrote: > Hi all, > > I've got a webrev here that allows pkgdepend users to bypass generation > of dependencies against certain files and allows them to modify the > runpath that pkgdepend produces. I'd appreciate a code review please? > > http://cr.opensolaris.org/~timf/pkgdep-python-webrev/
Brock wanted somebody else to look at this, and I wanted to peek att it before going back to the onnv-gate webrev, so... Seems like you and Brock are discussing what might be significant changes in src/modules/publish/dependencies.py, so this is really a cursory review of the remaining fixes. src/man/pkgdepend.1.txt 93: s/option can/option, can/ src/modules/flavor/base.py 61: "in manifest" seems like poor phrasing; it's "on the same action," isn't it? 72-73: s/ additional// 78-92: seems like this could be guarded by "not run_paths," since you'll completely disregard it on 108? 323-325: you can simply get rid of 323-324, can't you? src/modules/flavor/elf.py 197-199: Is it not valid to use usr/platform/*/kernel? (Not a high priority, since I don't think we actually deliver anything there.) 242: You go to a lot of trouble to build the default runpath rp and then ignore it if run_paths is set and doesn't include PD_DEFAULT_RUNPATH. > My plan is to get this change putback to the pkg-gate once reviewed, > then work with the ON gatekeepers to find a good time to force the > gatelings to upgrade to these pkg bits, via flag day. > > I'll then push the corresponding ON changes (I've a bit more work to do > for sparc, i386 is looking good) that use this new functionality, but > will probably leave pkgdepend error-checking in its current state. > > Once that's done, I'll merge and push the ON pkglint changes and enable > pkgdepend error checking at the same time. > > cheers, > tim > > > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
