Hi Brock, On Mon, 2011-02-07 at 16:51 -0800, Brock Pytlik wrote: > > In the meantime, I've got the 'generate' part of the fix done now - the > > 'resolve' side is a bit more involved (need to mark each error produced > > with the pkg.debug.depend.group tag responsible, if any) > > Wow, that's complicated :D
Yes it was! There's an incremental webrev with these changes at: http://cr.opensolaris.org/~timf/pkgdep-python-webrev-v0-vs-v1 > Just as a suggestion, had you thought of perhaps adding a "completepath" > tag to the generated depend action. I was wondering about that - it'd certainly make the bypass mechanism a lot easier to swallow: multiply the runpaths by the basenames, then drop the ones that match any bypass-list entries. It would also fix an outstanding nit I've got, where the p.d.d.file for a python module "foo" gets set to include "foo/__init__.py" - so it's not really a filename, and so a bypass entry of "*/__init__.py" doesn't actually match it (because we're not globbing against the full path name, rather matching the basename of the bypass-list entry against the p.d.d.file list) > It'd be nice if we had a single path through this code, instead of > only using the group code (or the completepath code) on Tuesday during > a fall eclipse. Yep, totally agree. > If you go with the complete path idea, I think it might be as simple as > moving the step where we run make_paths (in publisher/dependencies) > during the generate phase instead of the resolve phase. > Let me know what you think, I'll go with expanding the dependencies to a set of completepath entries if we're doing bypassing, but otherwise will leave the dependencies alone (they're more compact that way) and will drop the grouping stuff. In that case, the webrev above is a bit redundant - although it does have a few fixes for things you pointed out in the review. Thanks for the nudge to come up with a better solution :) cheers, tim _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
