Hi Mark,
On Mon, 2011-02-07 at 19:29 -0700, Mark J. Nelson wrote:
> > http://cr.opensolaris.org/~timf/pkgdep-python-webrev/
>
> Brock wanted somebody else to look at this, and I wanted to peek att it
> before going back to the onnv-gate webrev, so...
Great, thanks for taking a look!
> Seems like you and Brock are discussing what might be significant
> changes in src/modules/publish/dependencies.py, so this is really a
> cursory review of the remaining fixes.
>
> src/man/pkgdepend.1.txt
> 93: s/option can/option, can/
Yep, fixed.
> src/modules/flavor/base.py
> 61: "in manifest" seems like poor phrasing; it's "on the same action,"
> isn't it?
Yes. How about:
"More than one $PKGDEPEND_RUNPATH token was set on the same action in
this manifest"
The below are for src/modules/flavor/depthlimitedmf.py
> 72-73: s/ additional//
Thanks.
> 78-92: seems like this could be guarded by "not run_paths," since you'll
> completely disregard it on 108?
I don't think so - we want $PKGDEPEND_PATH to expand to include both the
standard system paths and the user-set $PYTHONPATH. Maybe I'm
misunderstanding you?
The below is for src/modules/flavor/depthlimitedmf24.py I think
> 323-325: you can simply get rid of 323-324, can't you?
Yep, thanks (I didn't know about that - I was expecting an IndexError)
> src/modules/flavor/elf.py
> 197-199: Is it not valid to use usr/platform/*/kernel? (Not a high
> priority, since I don't think we actually deliver anything there.)
I don't think so, not for kernel modules - it looks like
usr/src/uts/common/sys/modctl.h defines MOD_DEFPATH, then getmodpath()
in usr/src/uts/common/krtld/kobj.c calls a platform-specific
mach_modpath() defined in various platform-specific copies of mlsetup.c
[ I'm open to correction, I don't really live near that code, just
passing through :-) ]
> 242: You go to a lot of trouble to build the default runpath rp and then
> ignore it if run_paths is set and doesn't include PD_DEFAULT_RUNPATH.
That's true - I'll check for run_paths and PD_DEFAULT_RUNPATH before
doing all that work.
Thanks again for the review,
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
