On 07/ 7/11 09:10 PM, Shawn Walker wrote:
> https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-publish-1/webrev/
Only reviewing the man page -
- Under generate only two SVR4 package parameters are listed as being
converted, I'd have expected more, such as:
SVR4 pkginfo(4) pkg(5) action/attribute
--------------- -----------------------
ARCH (if not "all") variant.arch
PKG pkg.fmri name string
VERSION pkg.fmri version string
(common subset) legacy action
Does BASEDIR get added to paths?
- What does --target do in publish? Doesn't it not apply since the manifest
specifies which file is target vs. link?
- Example 1 fails when using csh or tcsh, since their echo builtins don't handle
"\n", specifying /usr/bin/echo fixes it for them.
- An example of using pkgsend generate might be nice. Especially if it showed
the requirement to add a "set pkg.fmri" manually when generating a manifest
from a non-SVR4 source, since you've removed the option to specify that on
the command line.
- eval(1) should be removed from See Also, since it was part of the old
transaction examples. I'm not sure why ftpusers(4), group(4),
passwd(4), shadow(4) were mentioned there - they would make sense for
discussion of user actions, but I don't see any mention of those.
- Should a mention/see also of pkglint be added for checking the generated
manifest, much as you have for pkgdepend?
- Even though it's now documented as pkgsend publish -s /path/to/repo, please
continue to accept pkgsend -s /path/to/repo publish for a few builds if
possible so we don't have to have a cross-consolidation flag day.
--
-Alan Coopersmith- [email protected]
Oracle Solaris Platform Engineering: X Window System
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
